Add utility function get_number_frames
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently no way to query a video container to determine the number of video frames that it contains, besides decoding video and counting the frames. While this is the best you can do for some container formats, other container formats can report the number of frames without decoding each video frame. I have added a new function, `get_number_frames`, which will query the container and return the number of frames, if applicable, or return `nothing` otherwise. This function will not decode the video stream in order to determine the number of frames. I have additionally added simple tests of this function, a documentation string, and added it to the docs.
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 76.83% 77.13% +0.30%
==========================================
Files 14 14
Lines 600 608 +8
==========================================
+ Hits 461 469 +8
Misses 139 139
Continue to review full report at Codecov.
|
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to query a video container to determine the number of video frames that it contains, besides decoding the video and counting the frames. While this is the best you can do for some container formats, other container formats can report the number of frames without decoding each video frame. I have added a new function,
get_number_frames, which will query the container and return the number of frames, if applicable, or returnnothingotherwise. This function will not decode the video stream in order to determine the number of frames.I have additionally added simple tests of this function, a documentation string, and added it to the docs.