Make some fields in VideoReader concrete types
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fields of `VideoReader`, `framerate` and `aspect_ratio`, are both of type
`Rational`, an abstract type. In reality, the constructor of `VideoReader` sets
both of these fields to be type `Rational{Cint}`. By changing the type
definition to reflect that, it reduces type instability in code accessing
`VideoReader` fields, while not restricting the generality of `VideoReader`.
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 77.09% 77.09%
=======================================
Files 14 14
Lines 598 598
=======================================
Hits 461 461
Misses 137 137
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fields of
VideoReader,framerateandaspect_ratio, are both of typeRational, an abstract type. In reality, the constructor ofVideoReadersets both of these fields to be typeRational{Cint}. By changing the type definition to reflect that, it reduces type instability in code accessingVideoReaderfields, while not restricting the generality ofVideoReader.