Fix one instance of type instability within VideoReader #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 77.09% 77.09%
=======================================
Files 14 14
Lines 598 598
=======================================
Hits 461 461
Misses 137 137
Continue to review full report at Codecov.
|
|
CI failure here was a download blip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
VideoReader's constructor,aspect_ratiois either set to the aspect ratio from the codec context, which is converted into aRational{Cint}, or instead0 // 1if the denominator is zero, which is aRational{Int}. This causes unceccessary type instability, which can be fixed by instead makingaspect_ratio = Cint(0) // Cint(1)if the denominator is zero.