updates for 0.7 and more systematic test output #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates for 0.7, including capturing logging output, which is a little more complicated because the logger caches STDERR, so it has to be handled separately.
This also reworks the testing so that it's more systematic. Previously there was a mix of things captured and things that were printed, and you had to read things carefully to figure out whether it was behaving correctly. The expected output is now as below. The incrementing numbers are so that you can tell if something got captured/suppressed that shouldn't have (there will be a skipped number) or if something doesn't get suppressed it'll show up in the output and say
SUPPRESSED
so it should be pretty obvious.At some point in the future it would probably be good to use the shell to pipe this output to a file and compare to an expected output.
Also there's getting to be a lot of duplication in the code. I'm planning on a separate PR to clean up the code a bit, but I figured keeping this separate would make it easier to review.