ProtoBuf 1.0.0 #202
Merged
ProtoBuf 1.0.0 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudimentary decoding codegen an codecs
* Make struct fields nullable by default (with an override) * Fix enum codegen test
Co-authored-by: Jacob Quinn <[email protected]> Co-authored-by: Jacob Quinn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
===========================================
+ Coverage 69.10% 89.16% +20.06%
===========================================
Files 19 25 +6
Lines 2690 2770 +80
===========================================
+ Hits 1859 2470 +611
+ Misses 831 300 -531
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I don't yet have the permissions necessary to merge PRs so, please, could you do the honors, @tanmaykm?:) And if possible, make me the owner of this repo, I need to set up Documenter secrets. |
|
I've added you as an admin @Drvi; merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #201
As mentioned in #201, this is a complete rewrite of the package, it does not quite reach feature parity with the current master, most noticeably we currently lack the ability to generate code for
Services andRPCs, we do hope to fix that in the near future. The version bump to 1.0.0 is certainly to signal a breaking change and not maturity:)Since this is a complete rewrite from scratch and we'll be happy to take over the maintenance of this package once this is merged, I've updated the
LICENSE.mdfile accordingly, please let me know if you are agree with the proposed changes.A believe this this change should fix some of the open issues:
cc: @quinnj