Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compats #183

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Bump compats #183

merged 3 commits into from
Aug 30, 2024

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Aug 29, 2024

This is causing v0.3 of Parquet to be installed on my machine. With this PR I get a functioning version.

This is causing v0.3 of Parquet to be installed on my machine.
@asinghvi17 asinghvi17 changed the title Bump CodecZlib compat Bump compats Aug 29, 2024
@nhz2
Copy link
Member

nhz2 commented Aug 29, 2024

Looks good to me. From what I can tell this downgrades Thrift.jl to v0.8.3 so I think it would be good to update https://github.com/tanmaykm/Thrift.jl/blob/13a8ffe063ef25acb64d5dec216a322a2e262560/Project.toml#L15 as well, but that is no reason not to release this.

@asinghvi17
Copy link
Member Author

Thanks for the review @nhz2! I will merge and release then, since tests pass locally for me on Mac M1 as well. This release does hold CEnum back because of a compat constraint in Snappy.jl, but I'll PR that there.

cc @tanmaykm

@asinghvi17 asinghvi17 merged commit f406366 into master Aug 30, 2024
9 of 11 checks passed
@asinghvi17 asinghvi17 deleted the asinghvi17-patch-1 branch August 30, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants