Add read/write of text formats #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an error and a deprecation warning.
timholy
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this branch add reading and writing of
netpbm"plain" formats to the package and tests for the new methods.Changes also fix #22, by adding tests for PBM binary formats and fixing a bug and a deprecation warning uncovered by the tests.
I'm happy to make any changes that will help this code conform with the existing code. Opinions are welcome on whether it's worth submitting changes so that FileIO.jl uses
Netpbm.jlfor allnetpbmI/O. I can do that if this PR is merged.