Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced REQUIRE files by a suitable Project.toml #17

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

magister-ludi
Copy link
Contributor

The changes allow Netpbm to be installed correctly with Julia v1.3 (see #16) I've kept the version at v0.3.1 Tests are passing.

@timholy
Copy link
Member

timholy commented Dec 10, 2019

Sweet! FYI we also need to add [compat] bounds on all the dependencies for this to be something that will be automatically merged to the General registry. But let's merge this since it's already an improvement.

@timholy timholy merged commit b32f74e into JuliaIO:master Dec 10, 2019
@magister-ludi
Copy link
Contributor Author

Sweet! FYI we also need to add [compat] bounds on all the dependencies for this to be something that will be automatically merged to the General registry. But let's merge this since it's already an improvement.

I'd be happy to try to do that. Can you point me to relevant documentation?

@timholy
Copy link
Member

timholy commented Dec 11, 2019

Documentation on the compat format: https://julialang.github.io/Pkg.jl/v1/compatibility/
For the announcement: https://discourse.julialang.org/t/announcement-automatic-merging-for-the-general-registry/29961

You can also see other packages' Project.toml files, e.g., ImageMagick.

@magister-ludi
Copy link
Contributor Author

Thanks for the tips. I'll take a look and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants