Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc with correct parameterized function syntax #336

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Update doc with correct parameterized function syntax #336

merged 4 commits into from
Feb 15, 2022

Conversation

o314
Copy link
Contributor

@o314 o314 commented Jan 25, 2022

This format is not supported since a long time.
Should we remap Associative to AbstractDict too ?

This format is not supported since a long time.
Should we remap Associative to AbstractDict too ?
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #336 (2833533) into master (f93688a) will decrease coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   99.51%   98.63%   -0.88%     
==========================================
  Files           5        5              
  Lines         410      441      +31     
==========================================
+ Hits          408      435      +27     
- Misses          2        6       +4     
Impacted Files Coverage Δ
src/Parser.jl 100.00% <ø> (ø)
src/JSON.jl 20.00% <0.00%> (-80.00%) ⬇️
src/specialized.jl 100.00% <0.00%> (ø)
src/Writer.jl 98.26% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93688a...2833533. Read the comment docs.

@singularitti
Copy link
Contributor

Hi, I guess you should also align the first line like parse(str::AbstractString; with the rest of the lines.

Beautify code at request
@o314
Copy link
Contributor Author

o314 commented Feb 15, 2022

This should be done now.
Nota that mentions to Associative have not been reviewed

src/Parser.jl Outdated Show resolved Hide resolved
src/Parser.jl Outdated Show resolved Hide resolved
o314 and others added 2 commits February 15, 2022 10:56
Fix mention to old Associative

Co-authored-by: Fredrik Ekre <[email protected]>
Co-authored-by: Fredrik Ekre <[email protected]>
@KristofferC KristofferC merged commit de16550 into JuliaIO:master Feb 15, 2022
@o314 o314 deleted the patch-1 branch February 15, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants