Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert 1.0 bump and tag + release 0.21.1 instead #310

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Sep 7, 2020

This allows us to get a new JSON version out to everyone with the latest bugfixes and improvements.

@KristofferC KristofferC closed this Sep 7, 2020
@KristofferC KristofferC reopened this Sep 7, 2020
@KristofferC
Copy link
Member Author

Unless someone objects I will merge and tag a new version in not too long.

@TotalVerb
Copy link
Collaborator

This will just move the maintenance burden to the 1.0 "branch" instead of the 0.21 "branch". I think this LGTM to get the fix out, but unfortunately we'll need to continue tagging each fix with both version numbers, it seems.

@KristofferC
Copy link
Member Author

KristofferC commented Sep 7, 2020

There is no 1.0 branch though, since 1.0 was never released.

Edit: Or it was, it was just not tagged here?

Edit: Edit: No it wasn't after all... https://github.com/JuliaRegistries/General/blob/master/J/JSON/Versions.toml

@TotalVerb
Copy link
Collaborator

TotalVerb commented Sep 7, 2020

Ah ok, then LGTM. Let's hold off on the 1.0 tag then. (I think that is still a good idea in principle, but will require some script to mass-PR repositories with an upgrade to their Compat.jl entries, plus a potential PR to the General repository. If someone wishes to volunteer this, it could be useful for many package migrations, but until then the change is too disruptive.)

@KristofferC KristofferC merged commit 2987b15 into master Sep 7, 2020
@giordano giordano deleted the KristofferC-patch-1 branch March 22, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants