-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse floats using Parsers.jl (fixes #284) #285
Conversation
I'll pull the transition to |
One Appveyor build failed because of a DNS lookup (unrelated). I hesitate to close and open just to run everything again, especially if I should make any changes, and I don't have permissions to restart just that build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Yeah, I understand the comment w/ wanting to use tryparse
and I've been meaning to update things to allow consuming the full input.
I'm not sure I have permission to restart appveyor either. I'm fine with the spurious failure since it's on 0.7 anyway. |
Looks like I was mistaken and the failure on the Compose build that pointed at the xparse line introduced by this PR was a false flag. Not sure what's causing the failure, but I'm trying to work that out now. Sorry for the spam. |
On my machine, this gives a good speedup on the (minimal) benchmarks that we have (and we now are faster than Python!):
Before:
After:
Python:
Cc: @quinnj @TotalVerb