change ordered keyword to dicttype keyword #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2015
|
lgtm. gotta love when adding generality fixes more problems than it introduces. worth changing minor pkg version for this, even if apparently unused in public code? |
| JSON.parse(io::IO; ordered=false) | ||
| JSON.parsefile(filename::AbstractString; ordered=false, use_mmap=true) | ||
| JSON.parse(s::AbstractString; dicttype=Dict) | ||
| JSON.parse(io::IO, dicttype=Dict) |
|
So very clean! |
…ility, and avoids the pseudo-dependency on DataStructures that was causing precompile problems
stevengj
added a commit
that referenced
this pull request
Oct 5, 2015
change ordered keyword to dicttype keyword
|
While I like this change, I've seen the ordered keyword used in the wild, so the next tag of JSON.jl is going to break some code. Any thoughts on deprecation or informing the user how to fix her code? |
|
@kmsquire, I couldn't find it in any registered packages. But one could certainly add an |
|
Thanks, yes, I mentioned that this was in user code. I'll add the exception when I get the chance. |
|
sorry for the hasty tag, should have cc'ed you sooner on this |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #128, this provides more flexibility, and avoids the pseudo-dependency on DataStructures that has been causing precompilation problems.