Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only warn for anon functions #597

Merged
merged 3 commits into from
Sep 14, 2024
Merged

only warn for anon functions #597

merged 3 commits into from
Sep 14, 2024

Conversation

JonasIsensee
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (3647927) to head (5ed91ab).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/data/writing_datatypes.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #597      +/-   ##
==========================================
- Coverage   85.19%   85.17%   -0.03%     
==========================================
  Files          36       36              
  Lines        4391     4391              
==========================================
- Hits         3741     3740       -1     
- Misses        650      651       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasIsensee JonasIsensee merged commit 05a4ee2 into dev Sep 14, 2024
14 of 16 checks passed
JonasIsensee added a commit that referenced this pull request Sep 18, 2024
* remove warning that is no longer relevant (#595)

* only warn for anon functions (#597)

* only warn for anon functions

* compat for v1.6

* can't test for warning if warning is removed

* improve test

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant