Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warning that is no longer relevant #595

Merged
merged 2 commits into from
Sep 14, 2024
Merged

remove warning that is no longer relevant #595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3647927
Merge pull request #593 from JuliaIO/dev
JonasIsensee Sep 8, 2024
436c675
remove warning that is no longer relevant
JonasIsensee Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/data/reconstructing_datatypes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,9 +592,8 @@ function reconstruct_odr(f::JLDFile, dt::CompoundDatatype,
i = findfirst(==(Symbol(k)), dt.names)
if typeref != NULL_REFERENCE
dtrr = jltype(f, f.datatype_locations[typeref])
odr_sizeof(dtrr) != 0 && @warn "Field $k has non-zero size in file, this should not happen"
elseif !isnothing(i)
offset = dt.offsets[i]
offset == dt.offsets[i] || throw(InternalError("Field offsets were incorrectly mapped."))
dtrr = jltype(f, dt.members[i])
else
throw(InternalError("Field $k not found in datatype"))
Expand Down
Loading