Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make read and write threadsafe #230

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Make read and write threadsafe #230

merged 2 commits into from
Oct 1, 2020

Conversation

JonasIsensee
Copy link
Collaborator

This PR aims to make reading and writing independent files on multiple threads possible
by removing unnecessary global states and protecting necessary ones with ReentrantLocks.

Somehow this should have tests..

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #230 into master will increase coverage by 0.80%.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   89.11%   89.91%   +0.80%     
==========================================
  Files          21       21              
  Lines        2241     2410     +169     
==========================================
+ Hits         1997     2167     +170     
+ Misses        244      243       -1     
Impacted Files Coverage Δ
src/JLD2.jl 96.25% <97.43%> (+0.44%) ⬆️
src/datasets.jl 95.79% <100.00%> (+0.30%) ⬆️
src/mmapio.jl 81.88% <100.00%> (+1.41%) ⬆️
src/stdlib.jl 96.66% <100.00%> (+0.51%) ⬆️
src/misc.jl 100.00% <0.00%> (ø)
src/attributes.jl 100.00% <0.00%> (ø)
src/backwards_compatibility.jl 100.00% <0.00%> (ø)
src/global_heaps.jl 97.36% <0.00%> (+0.10%) ⬆️
src/dataio.jl 97.31% <0.00%> (+0.21%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35fb186...9d9ca1f. Read the comment docs.

@JonasIsensee JonasIsensee merged commit fd6e395 into master Oct 1, 2020
@JonasIsensee JonasIsensee deleted the threadsafety branch February 6, 2021 15:39
@JonasIsensee JonasIsensee mentioned this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant