catch edge case on mac

JuliaIO · Sep 19, 2024 · 44c82bd · 44c82bd
1 parent 8cc1c73
commit 44c82bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/bufferedio.jl b/src/bufferedio.jl
@@ -14,7 +14,7 @@ function BufferedWriter(io, buffer_size::Integer = 0; extensible::Bool=false)
     pos = position(io)
     skip(io, buffer_size)
     buf = Vector{UInt8}(undef, buffer_size)
-    BufferedWriter(io, buf, pos, Ptr{Nothing}(pointer(buf)), extensible)
+    BufferedWriter(io, buf, Int64(pos), Ptr{Nothing}(pointer(buf)), extensible)
 end
 Base.show(io::IO, ::BufferedWriter) = print(io, "BufferedWriter")
 

diff --git a/src/mmapio.jl b/src/mmapio.jl
@@ -54,6 +54,8 @@ if Sys.isunix()
         offset_page::Int64 = div(offset, Mmap.PAGESIZE) * Mmap.PAGESIZE
         # add (offset - offset_page) to `len` to get total length of memory-mapped region
         mmaplen::Int64 = (offset - offset_page) + len
+        # Edge case: calling msync with 0 mmaplen fails on mac
+        mmaplen == 0 && return nothing
         systemerror("msync",
                     ccall(:msync, Cint, (Ptr{Cvoid}, Csize_t, Cint),
                           io.startptr + offset_page, mmaplen,