Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test HDF5_jll 1.12.2 #996

Closed
wants to merge 1 commit into from
Closed

test HDF5_jll 1.12.2 #996

wants to merge 1 commit into from

Conversation

visr
Copy link

@visr visr commented Jul 28, 2022

Locally it works fine for me, but I wanted to trigger CI here as well for other platforms.

JuliaPackaging/Yggdrasil#5248
https://github.com/JuliaBinaryWrappers/HDF5_jll.jl/releases/tag/HDF5-v1.12.2%2B0

visr added a commit to visr/Yggdrasil that referenced this pull request Jul 28, 2022
Should fix

```
dlopen(/Users/runner/.julia/artifacts/4e3d68673330116b7ef55a34b6d6d405e005fe6d/lib/libhdf5.200.dylib, 1): Library not loaded: @rpath/libcurl.4.dylib
  Referenced from: /Users/runner/.julia/artifacts/4e3d68673330116b7ef55a34b6d6d405e005fe6d/lib/libhdf5.200.dylib
  Reason: Incompatible library version: libhdf5.200.dylib requires version 13.0.0 or later, but libcurl.4.dylib provides version 12.0.0
```

From JuliaIO/HDF5.jl#996

Version 7.73 is the version that julia 1.6 uses:
https://github.com/JuliaLang/julia/blob/v1.6.6/stdlib/LibCURL_jll/Project.toml#L3

Just like JuliaPackaging#4981
@visr
Copy link
Author

visr commented Jul 28, 2022

The macOS failure should be fixed when JuliaPackaging/Yggdrasil#5249 is out.

Windows 32 bit has a single test failure:

AbstractString: Test Failed at D:\a\HDF5.jl\HDF5.jl\test\plain.jl:1237
  Expression: ext_prop.size == 10 * 20 * sizeof(Int)
   Evaluated: 0x0000000000000000 == 800

I thought it might be a Int32/Int thing, but that would not explain why the left hand side is 0.

@visr
Copy link
Author

visr commented Jul 28, 2022

Ok so HDF5_jll 1.12.2 is now yanked from the registry to avoid breaking this package for some users. Summary in JuliaPackaging/Yggdrasil#4511 (comment). Hope that we can somehow get that release distributed so we can finally get unstuck with NetCDF builds.

Feel free to merge this if you like space, or close.

@musm
Copy link
Member

musm commented Jul 28, 2022

I'll leave this open until the binaries get updated with the correct curl distribution? Sounds like that's the remaining problem.

@visr
Copy link
Author

visr commented Jul 28, 2022

Indeed that's the problem. I'm just not sure how to get those binaries at this point.

@visr
Copy link
Author

visr commented Jul 29, 2022

@musm and others, what do you think about the proposal in JuliaPackaging/Yggdrasil#4511 (comment)?

@mkitti
Copy link
Member

mkitti commented Jul 29, 2022

@visr My suggestion is make a registry edit to https://github.com/JuliaRegistries/General/blob/master/N/NetCDF/Compat.toml for HDF5_jll v1.12.0.

@visr
Copy link
Author

visr commented Jul 29, 2022

Could you elaborate? I think the problem is that for libnetcdf there is no libhdf5 version that works on all platforms, including newer platforms. Registry edits cannot be platform specific.

@mkitti
Copy link
Member

mkitti commented Jul 29, 2022

Is there a platform that does not work with HDF5 v1.12.0? I thought the problem was particular to HDF5 v1.12.1.

@visr
Copy link
Author

visr commented Jul 29, 2022

I believe so, macOS M1 and other platforms on 1.8, see Alexander-Barth/NCDatasets.jl#182 (comment).

@mkitti
Copy link
Member

mkitti commented Jul 29, 2022

Hmm, let me read more about this.

@visr
Copy link
Author

visr commented Jul 29, 2022

When I compare 1.12.1 and 1.12.0 in https://github.com/JuliaBinaryWrappers/HDF5_jll.jl/releases there is one extra asset, HDF5.v1.12.1.aarch64-apple-darwin.tar.gz.

@visr visr closed this Jul 29, 2022
@visr visr reopened this Jul 29, 2022
@visr
Copy link
Author

visr commented Jul 29, 2022

I triggered CI with the new build, and as can be expected macOS passes again since the build is the same as before.

And, also as expected, Windows 32 bits still fails just like I mentioned above in #996 (comment).

Does anyone have any ideas there? Or should we just mark the test as broken?

@mkitti
Copy link
Member

mkitti commented Jul 29, 2022

I don't see the Win32 x86 test failure as a huge blocker especially if the fix involves just downgrading HDF5_jll

@visr
Copy link
Author

visr commented Jul 29, 2022

Yeah it's only one failure, which seems to suggest that overall it works, though I don't understand the importance of this particular test, what the consequences are of it being broken.

@mkitti
Copy link
Member

mkitti commented Jul 29, 2022

I'll investigate this over the weekend.

@mkitti
Copy link
Member

mkitti commented Jul 30, 2022

I believe the x86 Windows issue is partially resolved via #998 . There is also an upstream bug in HDFGroup/hdf5#1821

@mkitti mkitti mentioned this pull request Jul 30, 2022
@musm musm closed this in #998 Jul 30, 2022
@visr visr deleted the patch-1 branch July 31, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants