Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Google URLs #12

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Support new Google URLs #12

merged 6 commits into from
Oct 3, 2023

Conversation

JeffFessler
Copy link
Member

This PR is aimed to address #6 by providing a simple function that just adapts the URL appropriately. It also supports downloading into an IO instead of insisting on a file.

If the functions seem OK, then I'll document them. For now this is a RFC...

@JeffFessler JeffFessler marked this pull request as draft October 2, 2023 16:14
@JeffFessler JeffFessler requested a review from sjkelly October 2, 2023 16:14
@flexagoon
Copy link
Contributor

Why aren't you using replace for the link format method?

@JeffFessler
Copy link
Member Author

Why aren't you using replace

Doh, I forgot about it. I will update. But first I need to fix the doc build in a separate PR...

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cdd05df) 9.87% compared to head (80b4439) 9.87%.

❗ Current head 80b4439 differs from pull request most recent head f0ff7d4. Consider uploading reports for the commit f0ff7d4 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #12   +/-   ##
======================================
  Coverage    9.87%   9.87%           
======================================
  Files           1       1           
  Lines          81      81           
======================================
  Hits            8       8           
  Misses         73      73           
Files Coverage Δ
src/GoogleDrive.jl 9.87% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Update doc.yml

* fix

* add Project.toml

* fix

* add ci
@JeffFessler
Copy link
Member Author

@sjkelly ok, now it uses replace. Comments?

Copy link
Member

@sjkelly sjkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. It was not clear immediately what was the relevant change. In general it makes it easier for review if you rebase, rather than merge FYI.
Also it is good practice to make commits and changes small and related. There are doc string additions here too.

@JeffFessler
Copy link
Member Author

Sorry about my bad git hygiene. Hopefully someday there will be a rebase button in the gui! https://github.com/orgs/community/discussions/22281
I will try to figure out a command line rebase in the future.

Just one comment about the docstring though. I did not actually add a docstring to the function unshortlink if that's the one you were mentioning. If you look at the original code, that docstring was a few blank lines away from the function it was documenting, so had no effect! I just removed those blank lines. It's a bit hard to see in the diff.

@JeffFessler JeffFessler marked this pull request as ready for review October 2, 2023 22:27
@JeffFessler
Copy link
Member Author

I've updated the README now and I will merge tomorrow unless anyone objects before then. The merge will show us the updated README and the Docs (hopefully) and then I can refine if needed before releasing 0.2.
Later someone can remove unneeded code if they want,
but at this stage I just want to add, not deprecate.

@JeffFessler JeffFessler merged commit 56a648c into master Oct 3, 2023
@JeffFessler JeffFessler deleted the jf/down branch October 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants