-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new Google URLs #12
Conversation
Why aren't you using |
Doh, I forgot about it. I will update. But first I need to fix the doc build in a separate PR... |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
======================================
Coverage 9.87% 9.87%
======================================
Files 1 1
Lines 81 81
======================================
Hits 8 8
Misses 73 73
☔ View full report in Codecov by Sentry. |
* Update doc.yml * fix * add Project.toml * fix * add ci
@sjkelly ok, now it uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. It was not clear immediately what was the relevant change. In general it makes it easier for review if you rebase, rather than merge FYI.
Also it is good practice to make commits and changes small and related. There are doc string additions here too.
Sorry about my bad git hygiene. Hopefully someday there will be a rebase button in the gui! https://github.com/orgs/community/discussions/22281 Just one comment about the docstring though. I did not actually add a docstring to the function |
I've updated the README now and I will merge tomorrow unless anyone objects before then. The merge will show us the updated README and the Docs (hopefully) and then I can refine if needed before releasing 0.2. |
This PR is aimed to address #6 by providing a simple function that just adapts the URL appropriately. It also supports downloading into an
IO
instead of insisting on a file.If the functions seem OK, then I'll document them. For now this is a RFC...