Add MIDI format #323
Merged
Add MIDI format #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 87.33% 87.01% -0.33%
==========================================
Files 10 10
Lines 624 624
==========================================
- Hits 545 543 -2
- Misses 79 81 +2
Continue to review full report at Codecov.
|
|
I've tagged MIDI 1.12.4 which has this; some basic test here can be added by using |
johnnychen94
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've added the support for MIDI formats. The I/O implementation is here at JuliaMusic/MIDI.jl/pull/140. Should this PR be merged before the MIDI.jl PR gets merged? Would love your help on which one to do first!