Reimplement find_decompressed_size without using static-only API #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkitti
force-pushed
the
mkitti-find_decompressed_size
branch
from
230a7aa to
59c54c3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
===========================================
+ Coverage 36.96% 61.55% +24.59%
===========================================
Files 5 5
Lines 560 372 -188
===========================================
+ Hits 207 229 +22
+ Misses 353 143 -210 ☔ View full report in Codecov by Sentry. |
mkitti
force-pushed
the
mkitti-find_decompressed_size
branch
from
51ed658 to
5b411e8
Compare
mkitti
force-pushed
the
mkitti-find_decompressed_size
branch
from
ff636f7 to
813632f
Compare
nhz2
requested changes
Sep 6, 2024
Co-authored-by: Nathan Zimmerberg <[email protected]>
Co-authored-by: Nathan Zimmerberg <[email protected]>
nhz2
approved these changes
Sep 7, 2024
|
Is this a breaking change? |
|
No, but we can add some downstream tests to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #62, that implements
ZSTD_findDecompressedSizeasfind_decompressed_sizein Julia using the public (non-static-only) API.ZSTD_getFrameContentSizeonly obtains the decompressed size of a single frame.find_decompressed_sizeobtains the accumulated size over multiple frames.find_decompressed_sizeshould continue to respond identically toZSTD_findDecompressedSize.