Add ZlibError type and move initialize into startproc
#93
+132
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 91.66% 82.97% -8.69%
==========================================
Files 4 4
Lines 156 188 +32
==========================================
+ Hits 143 156 +13
- Misses 13 32 +19 ☔ View full report in Codecov by Sentry. |
nhz2
added a commit
to nhz2/ZipStreams.jl
that referenced
this pull request
Jan 13, 2025
JuliaIO/CodecZlib.jl#93 adds a new error type for decompression errors. This PR updates some tests to be compatible with this change.
|
@reallyasi9 Could you please take a look at this PR? It breaks one of the tests in ZipStreams.jl, but I think the new error message is clearer. |
reallyasi9
added a commit
to reallyasi9/ZipStreams.jl
that referenced
this pull request
Jan 28, 2025
Attempts to address downstream breakage introduced in JuliaIO/CodecZlib.jl#93
|
Seems like the right thing to do. I just pulled into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies parts of JuliaIO/CodecBzip2.jl#41 and JuliaIO/CodecZstd.jl#74 to this package.
This PR turns the
initializefunction into a noop. Thestartprocfunction now automatically handles the initialization if the stream state is null.Fixes #89 fixes #59 and partially fixes #48 (a future PR is required to prevent memory leaks)
For example, decompressing a truncated stream:
master:
This PR: