Provide a simple source build fallback #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of this writing, BinaryBuilder does not support all of the platforms supported by Julia, which means that CodecZlib is not usable on those systems. This provides a simple fallback for building from source, using the same version of zlib used by ZlibBuilder.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this writing, BinaryBuilder does not support all of the platforms supported by Julia, which means that CodecZlib is not usable on those systems. This provides a simple fallback for building from source, using the same version of zlib used by ZlibBuilder.
With these changes, CodecZlib builds and passes all tests on FreeBSD 11.1, Julia 0.7.0-DEV.4706.