fix bug in original bsdiff program use of memcmp for string compare #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 95.00% 95.08% +0.08%
==========================================
Files 1 1
Lines 120 122 +2
==========================================
+ Hits 114 116 +2
Misses 6 6 Continue to review full report at Codecov.
|
StefanKarpinski
changed the title
StefanKarpinski
force-pushed
the
sk/diff-fix
branch
from
3d23178 to
ebeb062
Compare
StefanKarpinski
force-pushed
the
sk/diff-fix
branch
from
ebeb062 to
73e4797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
bsdiffprogram usesmemcmp(old, new, min(length(old), length(new)))to lexicographically compare strings, but this is wrong in the case where they are equal up to the length of the shorter of the two strings. Whenmemcmpreturns zero, the tie should be broken by comparing the lengths of the strings, the shorter one coming first. This version makes slightly better patches, but the difference is rarely very significant. The patch format is unchanged, so patches produced by the Julia library can be consumed by the command and vice versa, but they no longer produce identical patches (the compression might have been different anyway).