Test motion-related functions #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 11, 2024
cncastillo
approved these changes
Dec 12, 2024
|
I have added a method for |
|
@pvillacorta this is ready to be merged? |
- Fix error in tests - Fix flow-related undetected errors from #531
cncastillo
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to solve #412 and #522, thus improving code coverage.
I have also included some additional changes:
outflow_spin_reset!function when the input argument type isMotion. I forgot to add this in #517.plot_phantom_map.FlowPathread_phantomandwrite_phantomfunctions to better fit the newTimeCurvestructure.