Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow-related functions #516

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Fix flow-related functions #516

merged 6 commits into from
Dec 12, 2024

Conversation

pvillacorta
Copy link
Collaborator

@pvillacorta pvillacorta commented Dec 5, 2024

This PR is intended to solve some problems with flow experiments. Essentially:

  • We need to correct how the interpolation of the reset flags is performed. The get_mask function was incorrectly implemented (there was an unnecessary cumsum, which in fact caused the reset flag to be 1 at less time points than it should).
  • We need to ensure that, during the discretization of the sequence, time points corresponding specifically to spin jumps are included. Otherwise, we might miss a jump if no evaluation time instant falls within the interval where the reset bit should equal 1.

@pvillacorta pvillacorta marked this pull request as draft December 5, 2024 18:48
@pvillacorta pvillacorta marked this pull request as ready for review December 10, 2024 12:12
@pvillacorta pvillacorta marked this pull request as draft December 10, 2024 16:09
@pvillacorta pvillacorta marked this pull request as ready for review December 10, 2024 16:20
KomaMRIBase/src/motion/NoMotion.jl Outdated Show resolved Hide resolved
@cncastillo cncastillo merged commit 146510f into master Dec 12, 2024
8 of 12 checks passed
@cncastillo cncastillo deleted the fix-flow branch December 12, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants