KomaMRIFiles: RF phase read with the opposite sign from Pulseq #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncastillo
changed the title
|
From discussion #311: "Hi! We realized that the phase compensation was correct!! We added a test to verify it. The problem was the RF phase, which was read with a minus sign from the Pulseq (KomaMRIFiles), and then plotted with another minus sign🤦(KomaMRIPlots), so it looked fine. The fix is in #315 There was a sneaky A' instead of a transpose(A) when plotting that conjugated the RF complex amplitude and therefore the -phase. We will upload a patch ASAP." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a portion of discussion #311. Thanks to the community, we discovered that we were not properly plotting or reading Pulseq files due to a bug involving a minus sign and transposition.