Create some new options for BFSIterator
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 120 120
Lines 6953 6956 +3
=======================================
+ Hits 6766 6769 +3
Misses 187 187 ☔ View full report in Codecov by Sentry. |
|
Bump, I have some use cases for this, it should be easy to review |
|
Can someone take a look? |
gdalle
requested changes
Sep 25, 2024
Co-authored-by: Guillaume Dalle <[email protected]>
|
let me know if you have more review suggestions @gdalle and thank you for taking a look! |
|
Let me know if there is still something to address @gdalle |
|
If you could release a new version with this I would be grateful so that I can use it in another package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288.
This PR adds 2 new options, which can be useful when iterating in BFS:
depth_limit: specify the maximum level at which BFS should stop beforehand.neighbors_type: specify which function to use when iterating in BFS, e.g. sometimes usinginneighborscould be useful and this allows that