-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate flow algorithms from GraphsFlows #329
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 97.30% 97.41% +0.10%
==========================================
Files 115 124 +9
Lines 6796 7259 +463
==========================================
+ Hits 6613 7071 +458
- Misses 183 188 +5 ☔ View full report in Codecov by Sentry. |
Tests are failing because type inference in 1.6 is less good than in 1.10. They didn't use to in the original repo, presumably because of generic graphs. @simonschoelly maybe you could help? |
I'm good with it yup thanks! |
This is the part that is not well inferred for @traitfn residual(flow_graph::::IsDirected) = Graphs.DiGraph(Graphs.Graph(flow_graph)) |
Can I suggest that we move everything initially to the
|
That's a good idea but as for tracking changes, beyond renaming I only did the bare minimum so that the code could run. A lot of initial changes are gonna be necessary even in the |
Also I'm a bit lazy at the prospect of redoing all of these necessary changes from scratch just so we can track the renaming, but I understand your point |
Closing this to reopen a cleaner PR separating the copypaste from the actual changes to GraphsFlows |
Take everything in GraphsFlows.jl and put it in Graphs.jl.
This is half of the solution to #108
src/flows
test/flows
docs/src/flows.md
src/Graphs.jl
andtest/runtests.jl
anddocs/make.jl
to include necessary files@matbesancon since it's your code do you have anything to say about this?