Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in shell_layout (included in PR #186) #181

Closed
wants to merge 1 commit into from

Conversation

hdavid16
Copy link
Contributor

@hdavid16 hdavid16 commented Jul 27, 2022

shell layout assumed that the nlist had nodes in increaseing order. However, it should support lists with non-continuous vertices. This is now supported.

Fix #149

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #181 (4c1f900) into master (52f4aae) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   32.92%   32.92%           
=======================================
  Files           9        9           
  Lines         565      565           
=======================================
  Hits          186      186           
  Misses        379      379           
Impacted Files Coverage Δ
src/layout.jl 48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hdavid16 hdavid16 changed the title fixed #149 Fix error in shell_layout Aug 2, 2022
@hdavid16 hdavid16 mentioned this pull request Aug 5, 2022
@hdavid16 hdavid16 changed the title Fix error in shell_layout Fix error in shell_layout (included in PR #186) Aug 5, 2022
@hdavid16 hdavid16 closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect location order returned by shell_layout
1 participant