Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EvolveGCNO temporal layer #489

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Add EvolveGCNO temporal layer #489

merged 9 commits into from
Sep 17, 2024

Conversation

aurorarossi
Copy link
Member

No description provided.

@aurorarossi
Copy link
Member Author

I'm blocked on the following error in GNNLux when computing the gradient for EvolveGCNO:

Error During Test at /home/runner/work/GraphNeuralNetworks.jl/GraphNeuralNetworks.jl/GNNLux/test/layers/temporalconv_test.jl:51
  Got exception outside of a @test
  MethodError: no method matching +(::Base.RefValue{Any}, ::@NamedTuple{contents::FillArrays.Fill{Float32, 2, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}}}})

Any idea what the problem might be?

@CarloLucibello
Copy link
Member

mhmm, could be a bug in Zygote. Maybe try to simplify temporarily the logic of the layer and see if it disappears

@aurorarossi aurorarossi closed this Sep 9, 2024
@aurorarossi aurorarossi reopened this Sep 9, 2024
@aurorarossi
Copy link
Member Author

GNNLux tests work on my laptop.

@aurorarossi aurorarossi marked this pull request as ready for review September 14, 2024 18:29
@CarloLucibello CarloLucibello merged commit 2313a96 into JuliaGraphs:master Sep 17, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
temporalgraphs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurorarossi @CarloLucibello