Replace depreciated Flux.ADAM with Flux.Adam #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CarloLucibello I just noticed you created another PR that addresses this. I will close this. |
|
I actually I would prefer if we merge this PR instead of having an unrelated change in another PR |
mplemay
changed the title
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
- Coverage 86.44% 86.37% -0.08%
==========================================
Files 15 15
Lines 1365 1365
==========================================
- Hits 1180 1179 -1
- Misses 185 186 +1
Continue to review full report at Codecov.
|
|
We need to update Flux compat to 0.13.4 |
@CarloLucibello In this case would it make more sense to set the compatibility to |
|
See how it is done in #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the depreciated
Flux.ADAMoptimizer withFlux.Adamacross the entire project. This PR only changes, docs, performance benchmarks, tests, and examples so it should it should have not break end-user code.