Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GNNChain restructure bug #201

Merged
merged 2 commits into from
Jul 22, 2022
Merged

fix GNNChain restructure bug #201

merged 2 commits into from
Jul 22, 2022

Conversation

mplemay
Copy link
Contributor

@mplemay mplemay commented Jul 21, 2022

Hi this is my attempted fix for #200. Please let me know if there is anything I can do to improve this PR.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #201 (c4d562c) into master (401ae1a) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   86.56%   86.44%   -0.12%     
==========================================
  Files          15       15              
  Lines        1347     1365      +18     
==========================================
+ Hits         1166     1180      +14     
- Misses        181      185       +4     
Impacted Files Coverage Δ
src/layers/basic.jl 50.00% <100.00%> (+1.21%) ⬆️
src/GNNGraphs/gnngraph.jl 72.50% <0.00%> (-2.50%) ⬇️
src/layers/conv.jl 77.23% <0.00%> (-0.08%) ⬇️
src/GNNGraphs/sampling.jl 100.00% <0.00%> (ø)
src/GNNGraphs/query.jl 93.67% <0.00%> (+0.03%) ⬆️
src/GNNGraphs/transform.jl 96.96% <0.00%> (+0.05%) ⬆️
src/GNNGraphs/convert.jl 90.40% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401ae1a...c4d562c. Read the comment docs.

@CarloLucibello
Copy link
Member

thank you for this patch!

@CarloLucibello CarloLucibello merged commit 93b6fa2 into JuliaGraphs:master Jul 22, 2022
@mplemay mplemay deleted the fix-flux-restructure branch July 22, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants