Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing CI for pluto tutorials #174

Merged
merged 11 commits into from
May 27, 2022
Merged

fixing CI for pluto tutorials #174

merged 11 commits into from
May 27, 2022

Conversation

CarloLucibello
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #174 (65d75fc) into master (aa755dd) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   86.01%   86.27%   +0.26%     
==========================================
  Files          15       15              
  Lines        1323     1319       -4     
==========================================
  Hits         1138     1138              
+ Misses        185      181       -4     
Impacted Files Coverage Δ
src/GNNGraphs/utils.jl 95.94% <ø> (+4.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa755dd...65d75fc. Read the comment docs.

@rikhuijzer
Copy link

@CarloLucibello In graph_classification_pluto, don't forget to set

dataset = let
	ENV["DATADEPS_ALWAYS_ACCEPT"] = "true"
	TUDataset("MUTAG")
end

without that, the build fails locally here so probably also in CI

PackageSpec(; name="PlutoUI"),
]
Pkg.add(packages)
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikhuijzer a problem with this is that I get a very long terminal output in the notebook that I don't know how to suppress

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I just add all those packages to docs/Project.toml and activate that?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Pluto you mean right? In the few latest versions you can disable console output per cell. Select it at the top right of the cell. It remembers your choice also between runs

Copy link

@rikhuijzer rikhuijzer May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if you want to hide the code for a cell, use # hideall like in Documenter and Franklin:

# hideall
x = 1

will show only the output block containing 1. To hide code and output, use # hideall together with the semicolon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens with the visibility toggle in Pluto frontend? Isn't the visibility state stored in the cell metadata?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep nowadays it is. I have to implement reading that still. Added it to my task list a few minutes ago (rikhuijzer/PlutoStaticHTML.jl#119)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the visibility state stored in the cell metadata?

I've tested this now but apparently not no in 0.19.5

@CarloLucibello
Copy link
Member Author

hurrah!

@CarloLucibello CarloLucibello merged commit cdfb380 into master May 27, 2022
@rikhuijzer
Copy link

hurrah!

🥳 Looks like it works.

Can I add GraphNeuralNetworks.jl to the list of packages using PlutoStaticHTML.jl for documentation (https://huijzer.xyz/PlutoStaticHTML.jl/dev/#Documenter.jl)? You're also welcome to open a PR if you want

@CarloLucibello CarloLucibello deleted the cl/tutorials2 branch July 18, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants