Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cast rrule not needed anymore #135

Merged
merged 1 commit into from
Feb 24, 2022
Merged

remove cast rrule not needed anymore #135

merged 1 commit into from
Feb 24, 2022

Conversation

CarloLucibello
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #135 (2be04f3) into master (dd4a54c) will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   84.94%   85.43%   +0.49%     
==========================================
  Files          15       15              
  Lines        1262     1243      -19     
==========================================
- Hits         1072     1062      -10     
+ Misses        190      181       -9     
Impacted Files Coverage Δ
src/utils.jl 100.00% <ø> (+10.86%) ⬆️
src/GNNGraphs/utils.jl 74.00% <0.00%> (-1.25%) ⬇️
src/GNNGraphs/convert.jl 90.08% <0.00%> (-0.32%) ⬇️
src/GNNGraphs/query.jl 92.98% <0.00%> (-0.05%) ⬇️
src/GNNGraphs/sampling.jl 100.00% <0.00%> (ø)
src/layers/conv.jl 79.52% <0.00%> (+0.17%) ⬆️
src/GNNGraphs/transform.jl 96.71% <0.00%> (+0.43%) ⬆️
src/GNNGraphs/gnngraph.jl 77.61% <0.00%> (+3.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4a54c...2be04f3. Read the comment docs.

@CarloLucibello
Copy link
Member Author

julia 1.6 failure just a sporadic GATvs test failure

@CarloLucibello CarloLucibello merged commit 77f0e0f into master Feb 24, 2022
@CarloLucibello CarloLucibello deleted the cl/esp branch March 23, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant