Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement hash for GNNGraph #121

Merged
merged 9 commits into from
Jan 29, 2022
Merged

implement hash for GNNGraph #121

merged 9 commits into from
Jan 29, 2022

Conversation

CarloLucibello
Copy link
Member

Make sure that g and deepcopy(g) are hashed the same. This is relevant when graphs are used as dictionary keys (e.g. when used as states in the implementation of the MCTS in AlphaZero.jl).

cc @bhalonen

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #121 (f71dceb) into master (2493acf) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   82.97%   83.50%   +0.52%     
==========================================
  Files          15       15              
  Lines        1204     1194      -10     
==========================================
- Hits          999      997       -2     
+ Misses        205      197       -8     
Impacted Files Coverage Δ
src/GNNGraphs/gnngraph.jl 77.61% <100.00%> (+11.45%) ⬆️
src/GNNGraphs/utils.jl 69.76% <100.00%> (-0.35%) ⬇️
src/utils.jl 75.86% <0.00%> (-0.41%) ⬇️
src/GNNGraphs/convert.jl 89.74% <0.00%> (-0.34%) ⬇️
src/GNNGraphs/query.jl 92.94% <0.00%> (-0.05%) ⬇️
src/GNNGraphs/transform.jl 96.44% <0.00%> (-0.04%) ⬇️
src/GNNGraphs/sampling.jl 100.00% <0.00%> (ø)
src/layers/conv.jl 76.79% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2493acf...f71dceb. Read the comment docs.

test/layers/conv.jl Outdated Show resolved Hide resolved
test/layers/conv.jl Outdated Show resolved Hide resolved
@CarloLucibello CarloLucibello merged commit ff74af4 into master Jan 29, 2022
@CarloLucibello CarloLucibello deleted the cl/err branch March 23, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant