-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 0.5 support, fix some 0.7 deprecations #143
Conversation
Things are looking good on 0.6, but there's a pretty odd error on 0.7. There's a seemingly innocuous call: ccall((:g_type_init, Cairo._jl_libgobject), Cvoid, ()) For some reason, Julia 0.7 reacts with
I'm quite certain that's unrelated to the changes in this PR, but I'm not sure what's causing it. |
REQUIRE
Outdated
julia 0.5 | ||
Compat 0.17.0 | ||
julia 0.6 | ||
Compat 0.48.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.52 for objectid JuliaLang/Compat.jl@02367e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch, thanks!
This was an issue in Julia itself and has been fixed upstream.
@ararslan do you happen to know what are the plans for maintenance of this package? I personally do not use it now, but recently I got several questions if it is going to be ported to Julia 1.0 and maintained in the future. |
Are there depending packages? ImageView and recently also Winston have migrated to Gtk. |
I am not sure - but people simply want to use Tk in some legacy code I guess. |
I don't. This PR was so that Winston could work on 0.7, but as Tobias mentioned that's now using Gtk instead. The issue on 0.7 noted in this PR has been fixed in 0.7, so things should be in better shape. I don't know when I'll have time to revisit this PR since it's not exactly high priority for me, so if someone wants to start with the changes here and push it to completion then that would certainly be welcome. At this point I don't think it's worth trying to support 0.6, at least in my opinion. |
I reran CI on 0.7 and it appears there's still a long way to go in terms of fixing deprecations, which means 1.0 support is still a ways off. |
No description provided.