change print_escaped to escape_string
#136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`print_escaped` is depreciated in Julia v0.5 and give error in Julia v0.6-dev. i think this will help the pakage to run in Julia v0.6-dev.
|
This PR is good for windows only as the code is conditionally executed in windows. |
|
Thanks! We should probably set up appveyor for windows CI testing here |
correct for Julia v0.5 enviroment
re-correct the v.05 enviroment
DrKrar
commented
May 1, 2017
| - JULIAVERSION: "julialang/bin/winnt/x86/0.4/julia-0.4-latest-win32.exe" | ||
| - JULIAVERSION: "julialang/bin/winnt/x64/0.4/julia-0.4-latest-win64.exe" | ||
| - JULIAVERSION: "julialang/bin/winnt/x86/0.5/julia-0.5-latest-win32.exe" | ||
| - JULIAVERSION: "julialang/bin/winnt/x64/0.5/julia-0.5-latest-win64.exe" |
There was a problem hiding this comment.
I think this is the correct directory as it had worked for my package GeoEfficiency
|
Fixed by #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print_escapedis depreciated in Julia v0.5 and give error in Julia v0.6-dev. i think this will help the pakage to run in Julia v0.6-dev.