-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated bindings RGB4 RGB1 #557
Conversation
Require colortype 0.12
ColorTypes.jl registration PR: JuliaRegistries/General#117694 Let's re-run the CI in an hour or so. |
There is an ambiguity test failing:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 98.82% 96.75% -2.08%
==========================================
Files 10 9 -1
Lines 1281 1295 +14
==========================================
- Hits 1266 1253 -13
- Misses 15 42 +27 ☔ View full report in Codecov by Sentry. |
Commenting out the ambiguity test, everything else runs fine. |
Let me take a crack at fixing the ambiguity. |
Personally I think we should remove the Invalidations workflow, but we can do that later. |
Does this look good to you @ViralBShah? I haven't looked at other PRs. The docbuild failure is unfortunate but is perhaps better fixed separately. |
The doc changes are formatting related, and should be straightforward to fix separately. We should fix them before tagging the release. |
This removes the deprecated bindings for RGB4 and RGB1, see discussion:
JuliaIO/ImageMagick.jl#235
and similar fix in ColorTypes.jl
JuliaGraphics/ColorTypes.jl#312
It also requires the new version of ColorTypes in Compat, but that will cause failures until that version is registered.
CC: @ViralBShah, @ararslan