fixed parse StackOverflow and added Symbol/Colorant versions; closes … #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +72,7 @@ Returns: | |||
| - "hsla(h,s,l,a)" was used, in which case an `HSLA` color; | |||
| - a specific `Colorant` type was specified in the first argument | |||
| """ | |||
| function Base.parse(::Type{Colorant}, desc::AbstractString) | |||
| function _parse_colorant(desc::AbstractString) | |||
There was a problem hiding this comment.
This attaches the docstring to _parse_colorant when it should be attached to Base.parse.
|
Pushing additional commits to a PR doesn't send an email, so if you address review comments don't hesitate to also ping me. Let's wait a bit more for comments on #239. |
timholy
added a commit
that referenced
this pull request
Dec 6, 2015
fixed parse StackOverflow and added Symbol/Colorant versions; closes …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#232
Let me know if you'd like any adjustments or additional tests.