Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Artifacts #484

Merged
merged 6 commits into from
Feb 28, 2022
Merged

Use Artifacts #484

merged 6 commits into from
Feb 28, 2022

Conversation

pankgeorg
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #484 (e062a40) into master (91156f8) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   59.70%   59.84%   +0.13%     
==========================================
  Files          16       16              
  Lines         757      757              
==========================================
+ Hits          452      453       +1     
+ Misses        305      304       -1     
Impacted Files Coverage Δ
src/asset.jl 81.66% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91156f8...e062a40. Read the comment docs.

deps/bundlepaths.jl Outdated Show resolved Hide resolved

[[web.download]]
sha256 = "00debe8457bc840c81e204c482bada9098446aa12f5009c82b5c3b8b0281cebd"
url = "https://github.com/pankgeorg/WebIO.jl/files/8111257/bundle.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, would be good to get this automatically generated and hosted in this repo, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here is to make a release, add this there, do an extra commit with the link from the release assets and register that. Think of this as bootstrapping; are you thinking of something neater?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of doing that automatically, but I guess it's not worth the effort, considering the (hopefully) low number of future releases.

Co-authored-by: Sebastian Pfitzner <[email protected]>
@pfitzseb pfitzseb merged commit 8427e9e into JuliaGizmos:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants