Fix sending commands to multiple frontends. #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the way that new channels are added to a scope to work more synchronously and avoid some race conditions.
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 60.23% 60.23%
=======================================
Files 16 16
Lines 596 596
=======================================
Hits 359 359
Misses 237 237
Continue to review full report at Codecov.
|
|
Thanks! I can confirm that this fixes the original issue. I'll just need to update the |
rdeits
approved these changes
Aug 7, 2019
shashi
reviewed
Aug 8, 2019
| end | ||
| while isready(pool.new_connections) | ||
| push!(pool.connections, take!(pool.new_connections)) | ||
| wait(pool.condition) |
There was a problem hiding this comment.
Little tiny race condition possible here if a new condition arrives in between isempty and wait. This might need a lock, eventually.
shashi
reviewed
Aug 8, 2019
| sleep(0.25) | ||
| @test value(w1) == "updated" | ||
| @test value(w2) == "updated" | ||
| end |
|
Could we ask you guys for a new tag with this fix? CC:@rdeits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also reworks the way that new channels are added to a scope to work more
synchronously and avoid some race conditions.
Fixes #337 .