Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unify Julia + NPM publishing. #319

Merged
merged 15 commits into from
Jul 23, 2019
Merged

[WIP] Unify Julia + NPM publishing. #319

merged 15 commits into from
Jul 23, 2019

Conversation

twavv
Copy link
Member

@twavv twavv commented Jul 7, 2019

We shouldn't have to check built-in files to Git.

The easiest thing to do is to publish things to NPM and then download the current version when being installed.

@twavv
Copy link
Member Author

twavv commented Jul 9, 2019

I think publishing from CI is not gonna be the best route, here.

Instead I'm working on a publish.jl script which takes care of building the JS, testing against it, setting the NPM package versions, pushing to NPM, and creating the tag.

The reason why doing it in CI is problematic is because of the assumptions that Lerna make (which make sense when Lerna is the only tool being used to version... but... alas...).

@twavv twavv changed the title [WIP] Automated NPM CI publishing. [WIP] Unify Julia + NPM publishing. Jul 9, 2019
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #319 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage    62.6%   62.62%   +0.02%     
==========================================
  Files          17       16       -1     
  Lines         599      594       -5     
==========================================
- Hits          375      372       -3     
+ Misses        224      222       -2
Impacted Files Coverage Δ
src/iframe.jl 100% <ø> (ø) ⬆️
src/providers/generic_http.jl 73.07% <ø> (ø) ⬆️
src/WebIO.jl 77.77% <ø> (ø) ⬆️
src/providers/mux.jl 11.76% <0%> (+0.65%) ⬆️
src/devsetup.jl 50% <100%> (-10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f74ce4...4d070f8. Read the comment docs.

@twavv
Copy link
Member Author

twavv commented Jul 23, 2019

Closes #320.
Closes #317.
Closes #315.
Closes #314.
Closes #313.

@twavv
Copy link
Member Author

twavv commented Jul 23, 2019

Closes #264 (we always build before testing if checked out for development).

@twavv
Copy link
Member Author

twavv commented Jul 23, 2019

The VM which runs Julia 0.7 on Mac is apparently very flakey (it's happened twice where we get errors when it tries to download stuff from Conda). Going to merge this as is.

@twavv twavv merged commit 478266d into master Jul 23, 2019
@twavv twavv deleted the td/npm-ci-publish branch December 22, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant