-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Unify Julia + NPM publishing. #319
Conversation
I think publishing from CI is not gonna be the best route, here. Instead I'm working on a The reason why doing it in CI is problematic is because of the assumptions that Lerna make (which make sense when Lerna is the only tool being used to version... but... alas...). |
…nto td/npm-ci-publish
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 62.6% 62.62% +0.02%
==========================================
Files 17 16 -1
Lines 599 594 -5
==========================================
- Hits 375 372 -3
+ Misses 224 222 -2
Continue to review full report at Codecov.
|
Closes #264 (we always build before testing if checked out for development). |
The VM which runs Julia 0.7 on Mac is apparently very flakey (it's happened twice where we get errors when it tries to download stuff from Conda). Going to merge this as is. |
We shouldn't have to check built-in files to Git.
The easiest thing to do is to publish things to NPM and then download the current version when being installed.