Remove devsetup and clean up bundling #103
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #102, fixes #101
I was able to get rid of the
devsetup()
step entirely, and get rid of its associatednode_modules
folder indeps
. Since we were already doing anpm install
in thebundlejs()
step, I don't think there's much reason for a separatedevsetup()
.I've tightened the version restrictions in
package.json
and checked inpackage-lock.json
so we'll have a clear idea when package versions change. Unfortunately, this doesn't guarantee future compatibility, becausenpm install
overwrites, rather than respecting,package-lock.json
. It looks like making that guarantee will be possible withnpm 5.7.1
using thenpm ci
command: npm/npm#18286 (comment)By the way,
bundlejs(watch=true)
still works after this change 🙂Also, we should check if this helps with #79 and #94