-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not Compatible with JupyterLab 2.0.0 #397
Comments
The extension hasn't been updated for JupyterLab 2.0 yet. An immediate workaround would be to downgrade to JupyterLab v1 series. |
This is a workaround for #397 which causes tests to fail, but isn't a fix in that WebIO still isn't compatible with JupyterLab v2.
Hi! Is the latest workaround still to downgrade Jupyterlab to v1 series? |
Yes. I’m not sure how much has changed for extensions between 1 and 2 and haven’t had time to look at it yet unfortunately. |
Hello, do you think this would work even if compatibility is disregarded? |
Hi! Looking at the migration guide https://jupyterlab.readthedocs.io/en/stable/developer/extension_migration.html, I tried making the minimum number of changes needed for WebIO to run with JupyterLab 2.x. You can see them at master...lcontento:master. On my machine it appears basic functionality is restored, but maybe more work is still needed... Hope it may be useful (at least as a stopgap solution). |
Great, perhaps we could expect a PR sometime soon? |
@lcontento I have been using your branch over in a demo binder (repo) running JupyterLab 2.2.0 (and a lot of other stuff)... from a Julia perspective, while I can't seem to get LanguageServer.jl working properly, everything else is looking pretty good! |
Any chance the changes from @lcontento could be distilled into a PR and merged? We are also using this to make WebIO work on a recent jupyterlab installation in jupyterhub. |
I could try starting a PR with my changes, but I am not familiar enough with the code base to say whether additional changes need to be made. It would be best if after I start the PR one of the maintainers took over it. |
Open a PR and I can try to find a few spare hours to look it over. |
@lcontento what is the installation process to try out your changes? |
If I remember correctly it was quite straightforward. I don't think you need to install my version through the Julia package manager (the official package should work just fine, since I did not touch the Julia code). Just cloning my repository and running |
I got the following error
|
I thought that this issue would have been closed after #430 was merged. |
Thank you for the fast response! Yes, indeed I have Jupyterlab 3.... no wonder :-) |
Happy to help get any stuff up on jupyter lab 3, if my complete lack of
julia knowledge isn't too big a hindrance. It's hopefully a small json
change, and cutting a new release, but then will not require a julia user
to run (or even need) nodejs stuff after installing the extension, much
like classic notebook extensions.
If there are other extensions that depend on this one through the
jupyterlab side, it's slightly more complicated, but again hopefully just
json changes.
|
There is a new issue open... |
@Krisselack are you using |
Thank you, I tried that with the following result:
|
The bug
install_jupyter_labextension() fails
Context
Info:
The text was updated successfully, but these errors were encountered: