Fix SVG support. (#231)

* Fix SVG support. * Remove .js.map files from git.
JuliaGizmos · Nov 21, 2018 · 1225803 · 1225803
1 parent 116956c
commit 1225803
Show file tree

Hide file tree

Showing 12 changed files with 42 additions and 10 deletions.
diff --git a/.gitignore b/.gitignore
@@ -5,3 +5,4 @@ node_modules
 *.pyc
 deps/build.log
 *.ipynb_checkpoints
+*.js.map
diff --git a/packages/blink-provider/dist/blink.js b/packages/blink-provider/dist/blink.js
@@ -15665,14 +15665,17 @@ function (_WebIONode) {
           namespace = _data$instanceArgs.namespace,
           tag = _data$instanceArgs.tag;
 
-      switch (namespace) {
+      switch (namespace.toLocaleLowerCase()) {
         case "html"
         /* HTML */
         :
           return document.createElement(tag);
 
         case "http://www.w3.org/2000/svg"
         /* SVG */
+        :
+        case "svg"
+        /* SVG_SHORTHAND */
         :
           return document.createElementNS("http://www.w3.org/2000/svg"
           /* SVG */

diff --git a/packages/blink-provider/dist/blink.js.map b/packages/blink-provider/dist/blink.js.map
diff --git a/packages/generic-http-provider/dist/generic-http.js b/packages/generic-http-provider/dist/generic-http.js
@@ -15661,14 +15661,17 @@ function (_WebIONode) {
           namespace = _data$instanceArgs.namespace,
           tag = _data$instanceArgs.tag;
 
-      switch (namespace) {
+      switch (namespace.toLocaleLowerCase()) {
         case "html"
         /* HTML */
         :
           return document.createElement(tag);
 
         case "http://www.w3.org/2000/svg"
         /* SVG */
+        :
+        case "svg"
+        /* SVG_SHORTHAND */
         :
           return document.createElementNS("http://www.w3.org/2000/svg"
           /* SVG */

diff --git a/packages/generic-http-provider/dist/generic-http.js.map b/packages/generic-http-provider/dist/generic-http.js.map
diff --git a/packages/jupyter-notebook-provider/dist/main.js b/packages/jupyter-notebook-provider/dist/main.js
@@ -15492,14 +15492,17 @@ function (_super) {
         namespace = _a.namespace,
         tag = _a.tag;
 
-    switch (namespace) {
+    switch (namespace.toLocaleLowerCase()) {
       case "html"
       /* HTML */
       :
         return document.createElement(tag);
 
       case "http://www.w3.org/2000/svg"
       /* SVG */
+      :
+      case "svg"
+      /* SVG_SHORTHAND */
       :
         return document.createElementNS("http://www.w3.org/2000/svg"
         /* SVG */

diff --git a/packages/jupyter-notebook-provider/dist/main.js.map b/packages/jupyter-notebook-provider/dist/main.js.map
diff --git a/packages/mux-provider/dist/mux.js b/packages/mux-provider/dist/mux.js
@@ -15661,14 +15661,17 @@ function (_WebIONode) {
           namespace = _data$instanceArgs.namespace,
           tag = _data$instanceArgs.tag;
 
-      switch (namespace) {
+      switch (namespace.toLocaleLowerCase()) {
         case "html"
         /* HTML */
         :
           return document.createElement(tag);
 
         case "http://www.w3.org/2000/svg"
         /* SVG */
+        :
+        case "svg"
+        /* SVG_SHORTHAND */
         :
           return document.createElementNS("http://www.w3.org/2000/svg"
           /* SVG */

diff --git a/packages/mux-provider/dist/mux.js.map b/packages/mux-provider/dist/mux.js.map
diff --git a/packages/webio/lib/DomNode.d.ts b/packages/webio/lib/DomNode.d.ts
@@ -2,7 +2,8 @@ import WebIONode, { WebIODomElement, WebIONodeSchema, WebIONodeContext } from ".
 export declare const DOM_NODE_TYPE = "DOM";
 declare const enum DomNamespace {
     HTML = "html",
-    SVG = "http://www.w3.org/2000/svg"
+    SVG = "http://www.w3.org/2000/svg",
+    SVG_SHORTHAND = "svg"
 }
 /**
  * Props associated with a WebIO DOM node serialization.

diff --git a/packages/webio/src/DomNode.ts b/packages/webio/src/DomNode.ts
@@ -15,6 +15,7 @@ const enum DomNamespace {
   // "html" should actually be "http://www.w3.org/1999/xhtml" but it's okay
   HTML = "html",
   SVG = "http://www.w3.org/2000/svg",
+  SVG_SHORTHAND = "svg",
 }
 
 /**
@@ -96,10 +97,11 @@ class WebIODomNode extends WebIONode {
 
   private static createElement(data: DomNodeData) {
     const {namespace, tag} = data.instanceArgs;
-    switch (namespace) {
+    switch (namespace.toLocaleLowerCase()) {
       case DomNamespace.HTML:
         return document.createElement(tag);
       case DomNamespace.SVG:
+      case DomNamespace.SVG_SHORTHAND:
         return document.createElementNS(DomNamespace.SVG, tag);
       default:
         throw new Error(`Unknown DOM namespace: ${namespace}.`);

diff --git a/test/blink-tests.jl b/test/blink-tests.jl
@@ -106,6 +106,26 @@ end
     end
 end
 
+@testset "SVG/Namespaces" begin
+    window = Window(Dict(:show => false))
+
+    n = 10
+    color = "yellow"
+    h, w = 100, 100
+    attributes = Dict(
+        "fill" => color,
+        "points" => join(["$(w/2*(1+sin(θ))),$(h/2*(1+cos(θ)))" for θ in 0:2π/n:2π], ' '),
+    )
+    my_svg = dom"svg:svg[width=$w, height=$h]"(
+        dom"svg:polygon"(attributes=attributes),
+        attributes=Dict("data-test-key" => "1234"),
+    )
+    body!(window, dom"div"(my_svg))
+    sleep(5) # wait for it to render.
+    child_count = @js window document.querySelector("svg[data-test-key=\"1234\"]").childElementCount
+    @test child_count == 1
+end
+
 
 example_renderable_was_rendered = false