Signal propagation after topological sorting #9
Conversation
merge is still broken though.
| # A topological order | ||
| begin | ||
| local counter = uint(1) | ||
| const topo_rank = Dict{Signal, Uint}() |
There was a problem hiding this comment.
Why use a global Dict when you could just store the rank in the Signal?
There was a problem hiding this comment.
It made sense to keep the topological sorting logic out of Signal's structure. Besides there are many different signal types. This actually takes less code.
There was a problem hiding this comment.
The code saving is only the saving of adding a rank field to each Signal type. But the result is slower and, I think, more awkward.
(This is similar to the question of callbacks discussed recently with @one-more-minute.)
There was a problem hiding this comment.
Okay, that actually resulted in 4 lines less code :) c26c97b Thanks! Okay, I'll resist from doing this Dict thing again (pardon the slight mental disorder ;) ).
I guess I am just scared of letting code outside the library being able to so easily edit rank. I wish there was a way to make the signal object immutable except for the value field.
There was a problem hiding this comment.
You want something like C++'s private members. Julia doesn't enforce this kind of thing at the language level: it just relies on a cultural convention that external code generally shouldn't modify struct members directly (and if it does so, it does so at its own risk).
|
Do you think push! could be made more efficient in any way? This works and doesn't break the previous API. I think this is good to merge into master. |
1. Use topological sorting for signal proagation 2. More signal types: Filter, SampleOn, Merge, DropRepeats. Node is now abstract
Tries to address #4 .