Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try harder to find Jupyter and Python during build #206

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

stevengj
Copy link
Contributor

@stevengj stevengj commented Feb 15, 2018

This PR tries harder to correctly configure Interact on Windows.

On Windows, running jupyter subcommands can be tricky because of JuliaLang/IJulia.jl#363. I had to reproduce some of the logic from the IJulia build script here.

Also, it tries a bit harder on Windows to find python.exe, especially for Conda builds.

This also fixes the issue with @PYTHON_str mentioned in #205.

@stevengj
Copy link
Contributor Author

cc @alanedelman, hopefully this fixes the problem your student was having.

@alanedelman
Copy link

Thanks!

@stevengj
Copy link
Contributor Author

@shash, the CI failure on nightly seems unrelated ...

@shashi
Copy link
Member

shashi commented Feb 16, 2018

This looks good. Thanks!!

@shashi shashi merged commit dd62e50 into JuliaGizmos:master Feb 16, 2018
@stevengj
Copy link
Contributor Author

Alan, you may want to post on Piazza that students who had trouble getting @manipulate to work when they installed their own Julia on Windows should try: Pkg.checkout(“Interact”); Pkg.build(“Interact”) to get the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants