Add RNG to push function #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjkelly
approved these changes
Apr 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 87.21% 86.52% -0.70%
==========================================
Files 1 1
Lines 446 460 +14
==========================================
+ Hits 389 398 +9
- Misses 57 62 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was working with the VoronoiCells package and getting small differences when creating the tessellations with the same generator points, as can be seen in this issue.
Adding in a random number generator seems to fix that issue and I am now getting consistent answers.
It would be amazing if this pull request could be approved so that I can make a pull request with my fix to VoronoiCells as well. I am happy to change anything needed. Thank you!