Add Project.toml, fix tests on Julia 1.2 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The future is here
Changes introduced in Julia PR 30867
14 tasks
|
@tkoolen at this stage you're more of a maintainer of this package than myself ;-) I think it could make more sense for the Manifest to be considered a "build artifact" to be attached to a release by tagbot (or if staying within git, added automatically to a release branch). The benefit of having Manifest checked in would be to record a known tested version of all dependencies. But many such manifests could be valid at any given time. Checking in any version which just happened to be working on the developer's machine doesn't seem ideal. Also I think it would be likely to go stale unless there's some CI integration. |
|
OK, I agree. Will merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.