Add Rotations.params methods for RotationGenerator (#216)

* add tests for Rotations.params(::RotationGenerator) * add Rotations.params methods for RotationVecGenerator and Angle2dGenerator
JuliaGeometry · Jan 23, 2022 · 5319b35 · 5319b35
1 parent 62e4afd
commit 5319b35
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/rotation_generator.jl b/src/rotation_generator.jl
@@ -156,6 +156,7 @@ end
     end
 end
 
+@inline params(r::Angle2dGenerator) = SVector{1}(r.v)
 
 """
     struct RotationVecGenerator{T} <: RotationGenerator{2,T}
@@ -216,6 +217,7 @@ end
     end
 end
 
+@inline params(r::RotationVecGenerator) = SVector{3}(r.x,r.y,r.z)
 
 ################################################################################
 ################################################################################

diff --git a/test/rotation_generator.jl b/test/rotation_generator.jl
@@ -170,6 +170,11 @@
         @test_throws DimensionMismatch Angle2dGenerator(1) + RotationVecGenerator(2,3,4)
     end
 
+    @testset "params" begin
+        @test Rotations.params(Angle2dGenerator(1)) == [1]
+        @test Rotations.params(RotationVecGenerator(2,3,4)) == [2,3,4]
+    end
+
     @testset "type promotion" begin
         for (T, N) in ((Angle2dGenerator, 2), (RotationVecGenerator, 3))
             R = RotMatrixGenerator